Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify concurrency setting from proxy config #2216

Closed
wants to merge 1 commit into from
Closed

Clarify concurrency setting from proxy config #2216

wants to merge 1 commit into from

Conversation

timonwong
Copy link

Signed-off-by: Tianpeng Wang tpwang@alauda.io

It seems since istio/istio#32928, the concurrency behavior is changed so we need update the doc.

@timonwong
Clarify concurrency setting from proxy config
1fba1da 
Signed-off-by: Tianpeng Wang <tpwang@alauda.io>
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jan 21, 2022
@istio-testing
Copy link
Collaborator

Hi @timonwong. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn
Copy link
Member

I am not sure this is quite accurate. It is still the old behavior for some gateway install methods (https://istio.io/latest/docs/setup/additional-setup/gateway/).

Arhell
Arhell reviewed Jan 29, 2022
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 29, 2022
@istio-testing
Copy link
Collaborator

@timonwong: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
release-notes_api 1fba1da link false /test release-notes_api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericvn ericvn mentioned this pull request Feb 14, 2022
Closed
linsun
linsun reviewed Feb 22, 2022
View reviewed changes
mesh/v1alpha1/proxy.proto
Comment on lines +414 to +417
// For sidecars:
// If set to 0, this will be automatically determined based on CPU requests/limits.
// If positive n, then n worker threads will be used.
// Otherwise, defaults to 2 worker threads.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only for sidecar?

#2247

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 23, 2022
@istio-testing
Copy link
Collaborator

@timonwong: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@howardjohn howardjohn removed the needs-rebase Indicates a PR needs to be rebased before being merged label May 15, 2024
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2022-02-22. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linsun linsun linsun left review comments

@Arhell Arhell Arhell left review comments

@ericvn ericvn Awaiting requested review from ericvn

@howardjohn howardjohn Awaiting requested review from howardjohn

@louiscryan louiscryan Awaiting requested review from louiscryan

@nrjpoddar nrjpoddar Awaiting requested review from nrjpoddar

@smawson smawson Awaiting requested review from smawson

Assignees
No one assigned
Labels
lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@timonwong @istio-testing @howardjohn @istio-policy-bot @linsun @Arhell