Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authorization policy: allow specifying string match for path and conditions #2173

Closed
wants to merge 1 commit into from
Closed

Authorization policy: allow specifying string match for path and conditions #2173

wants to merge 1 commit into from

Conversation

sschepens
Copy link
Contributor

Add StringMatcher options to Path and Condition in AuthorizationPolicy.
We use the same StringMatcher as used in VirtualHosts to provide consistent matching in both.
If both String and StringMatcher are present, they should be appended.

Fixes istio/istio#16585
Related: istio/istio#35641

@howardjohn wdyt? this way we can prevent introducing breaking changes in the exiting APIs but still support matching by regex as needed.

@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-policy-bot
Copy link

😊 Welcome @sschepens! This is either your first contribution to the Istio api repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla bot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Nov 30, 2021
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Nov 30, 2021
@istio-testing
Copy link
Collaborator

Hi @sschepens. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebryant mikebryant mentioned this pull request Dec 2, 2021
Closed
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 16, 2022
@sschepens
Copy link
Contributor Author

@howardjohn what is your opinion on this? I would like to make progress on this feature, it is something that many people need.

@google-cla google-cla bot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Mar 22, 2022
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR needs to be rebased before being merged and removed needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2022
@istio-testing
Copy link
Collaborator

@sschepens: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@edieYoung edieYoung mentioned this pull request Jun 29, 2022
Closed
@teddy-wahle
Copy link

I would love for this PR to be merged! We really need this feature.

@timAdrien
Copy link

Yes please someone validate the PR, a lot of people are waiting this feature for so long

@howardjohn howardjohn mentioned this pull request Jul 21, 2023
Closed
@craigbox
Copy link
Contributor

Closing due to implementation in istio/istio#50365

@craigbox craigbox closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvn ericvn Awaiting requested review from ericvn

@howardjohn howardjohn Awaiting requested review from howardjohn

@linsun linsun Awaiting requested review from linsun

@louiscryan louiscryan Awaiting requested review from louiscryan

@nrjpoddar nrjpoddar Awaiting requested review from nrjpoddar

@smawson smawson Awaiting requested review from smawson

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. needs-ok-to-test needs-rebase Indicates a PR needs to be rebased before being merged size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support regex for ServiceRole spec.rules.paths
6 participants
@sschepens @istio-policy-bot @istio-testing @teddy-wahle @timAdrien @craigbox