Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added InterAppCommunication via /dev/iac #315

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added InterAppCommunication via /dev/iac #315

wants to merge 4 commits into from

Conversation

redbug26
Copy link

You have also to add TARGET_IS_EXTENSION in "Preprocessor Macros" like in this screen

sans titre 5

To test:

# Open iOS Settings
echo "App-prefs:root=General&path=Keyboard" > /dev/iac

# Open music
echo "music:" > /dev/iac

# Test x-callback (available also from any other application.. EG: type the url in safari)
echo "x-ish://x-callback-url/iac?output=username@gmail.com&password=myPassword" >/dev/iac
cat /dev/iac

Could be used to with Shortcut apps via something like

shortcuts://x-callback-url/run-shortcut?name=Calculate%20Tip&input=text&text=24.99&x-success=x-ish%3A%2F%2Fx-callback-url%2Fiac%3fresult

@tbodt
Copy link
Member

tbodt commented Feb 15, 2019

Thanks for taking the time to implement this! On first look this seems pretty good. One thing I'd want adjusted is the device number, which is currently 1,99. I would want to reserve an entire major number for iSH devices, and define an API for adding custom entries to the array in fs/dev.c. Looking at the list of allocated major numbers, 240 seems like a good choice, since major numbers from 240 to 254 are reserved for devices with no actual official major number. I'll review this a bit more later.

@redbug26
Copy link
Author

redbug26 commented Feb 15, 2019

No problem :)
Working on /proc/net/dev now :)

Copy link
Member

@saagarjha saagarjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a selection of unsolicited review that I thought you might find useful.

app/AppDelegate.m Outdated Show resolved Hide resolved
app/IOSGateway.h Outdated Show resolved Hide resolved
app/IOSGateway.m Show resolved Hide resolved
app/IOSGateway.m Outdated Show resolved Hide resolved
app/IOSGateway.m Outdated Show resolved Hide resolved
app/IOSGateway.m Show resolved Hide resolved
app/InterAppCommunication/IACClient.h Show resolved Hide resolved
app/InterAppCommunication/IACManager.m Show resolved Hide resolved
@jthoward64
Copy link

What is needed to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants