Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re: reordering #1944

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Re: reordering #1944

wants to merge 1 commit into from

Conversation

jason-conway
Copy link
Contributor

It’s not TSO, nor is it really an attempt at sequential consistency in any meaningful way. But, it has effectively eliminated the problems I was running into because of reordering- and the performance hit seems to be around 0.3% over a 20 minute test period.

You can test it with the following from within iSH (also runs on aarch64 if you're curious to see reordering frequency on M1 devices):

$ git clone https://gist.github.com/0a8dbfe1e7cab513837cbb2f26d995c5.git reordering && cd reordering
$ make

Then ./reordering before and after rebuilding with the barrier added.

emkey1 pushed a commit to emkey1/ish-AOK that referenced this pull request Nov 2, 2022
Added Jason Conway's Re Ordering patch (upstream PR ish-app#1944. Fix…
6cdefc1 
…ed a bunch of compiler complaints about uncast variables, removed "easter egg" for now.
jason-conway added a commit to emkey1/ish-AOK that referenced this pull request Nov 15, 2022
@jason-conway
Squashed commit of the following:
26dd852 
commit b35cea7
Author: Mike Miller <emkey1@oneopa.com>
Date:   Fri Nov 11 07:08:07 2022 -0800

    hostname now settable by root, uptime reports the time when the app was started rather than iDevice time, stuff in /proc gets app boot time for ctime and mtime and current time for atime.  Minor code cleanup

commit 5f0b712
Author: Mike Miller <emkey1@oneopa.com>
Date:   Mon Nov 7 08:55:25 2022 -0800

    Fix some of my stupid, remove last of the old extra locking stuff, make lint happier, check for pending signals before doing some things

commit 6cdefc1
Author: Mike Miller <emkey1@oneopa.com>
Date:   Wed Nov 2 15:27:58 2022 -0700

    Added Jason Conway's Re Ordering patch (upstream PR ish-app#1944.  Fixed a bunch of compiler complaints about uncast variables, removed "easter egg" for now.

commit 02b6bd0
Merge: 50eaba1 e73525e
Author: Mike Miller <emkey1@oneopa.com>
Date:   Sun Oct 30 10:08:56 2022 -0700

    Merge branch 'ish-app-master' into dev
    Upstream merge

commit e73525e
Merge: 50eaba1 0c0fa0f
Author: Mike Miller <emkey1@oneopa.com>
Date:   Sun Oct 30 10:08:32 2022 -0700

    Merge branch 'master' of https://github.com/ish-app/ish into ish-app-master

    Merging upstream

commit 50eaba1
Author: Mike Miller <emkey1@oneopa.com>
Date:   Sun Oct 30 10:04:24 2022 -0700

    Fixed elock so that it doesn't crash the app when toggled

commit e98aefd
Author: Mike Miller <emkey1@oneopa.com>
Date:   Sat Oct 29 19:24:27 2022 -0700

    Repurpose the enable_extralocking stuff to enable or disable additional thread coherency code, disable app_nap, preliminary checks to try to figure out if a non musl/Alpine release is running.

commit 0c0fa0f
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 28 06:09:13 2022 +0000

    Bump version to 429

commit 10533be
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 28 00:36:07 2022 +0000

    Update Alpine repositories

commit d79dbcf
Author: Mike Miller <emkey1@oneopa.com>
Date:   Thu Oct 27 16:58:46 2022 -0700

    Remove what little extra locking stuff remained.  It still appears in /proc/ish for backwards compatibility, but does nothing.

commit f578a0a
Author: Mike Miller <emkey1@oneopa.com>
Date:   Thu Oct 27 15:49:34 2022 -0700

    Some cleanup/fixing in regards to lock->comm, plus cleanup and bug fixing of a bogus unlock of &pid_lock that I introduced in August.

commit 5ac825c
Author: Mike Miller <emkey1@oneopa.com>
Date:   Wed Oct 26 19:36:09 2022 -0700

    More tweaks to reduce the odds of processes hanging.  Also disabled sse, as
    it was causing issues with ssl on Alpine.

commit e718794
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Oct 26 06:09:24 2022 +0000

    Bump version to 428

commit 11e8c7f
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Oct 26 00:35:53 2022 +0000

    Update Alpine repositories

commit 2b31cc6
Author: Theodore Dubois <tblodt@icloud.com>
Date:   Tue Oct 25 09:13:09 2022 -0700

    Update linux

commit 062067f
Author: Mike Miller <emkey1@oneopa.com>
Date:   Tue Oct 25 11:26:35 2022 -0700

    Checkpoint, much improved stability due to checking task->pending and not killing stuff when it is set.

commit 568eee3
Merge: 410615e 4daeff3
Author: Mike Miller <emkey1@oneopa.com>
Date:   Mon Oct 24 17:45:31 2022 -0700

    Merge branch 'ish-app-master' into dev
    Merged upstream

commit 4daeff3
Merge: 410615e 074ddee
Author: Mike Miller <emkey1@oneopa.com>
Date:   Mon Oct 24 17:45:04 2022 -0700

    Merge branch 'master' of https://github.com/ish-app/ish into ish-app-master

    Merged upstream changes

commit 074ddee
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Oct 24 06:38:30 2022 +0000

    Bump version to 427

commit 3aacc18
Author: Theodore Dubois <tblodt@icloud.com>
Date:   Sun Oct 23 22:11:08 2022 -0700

    Port emulator poke to arm

commit 0511e42
Merge: b24478a 7be7e0d
Author: tbodt <tblodt@icloud.com>
Date:   Sun Oct 23 19:30:27 2022 -0700

    Merge pull request ish-app#1933 from saagarjha/master

commit 7be7e0d
Author: Saagar Jha <saagar@saagarjha.com>
Date:   Sun Oct 23 18:18:57 2022 -0700

    Replace chatty syscall stubs with silent variant

    These syscalls have fallbacks in musl which we do implement but they are
    only invoked after they return ENOSYS, which fills dmesg with lots of
    spam.

commit b24478a
Author: Theodore Dubois <tblodt@icloud.com>
Date:   Sun Oct 23 17:20:55 2022 -0700

    Allow specifying kconfig for xcode

commit 4d722ed
Merge: 903919e f76e46a
Author: tbodt <tblodt@icloud.com>
Date:   Sun Oct 23 14:28:02 2022 -0700

    Merge pull request ish-app#1926 from jason-conway/i-make-money-movs

commit 903919e
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Oct 22 06:14:01 2022 +0000

    Bump version to 426

commit 611044e
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sat Oct 22 00:39:53 2022 +0000

    Update Alpine repositories

commit c07a1b5
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 21 06:20:33 2022 +0000

    Bump version to 425

commit 19cc084
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Fri Oct 21 00:36:22 2022 +0000

    Update Alpine repositories

commit defd059
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Thu Oct 20 06:14:37 2022 +0000

    Bump version to 424

commit f18a2b0
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Thu Oct 20 00:38:06 2022 +0000

    Update Alpine repositories

commit 5b2fbc8
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Oct 19 06:36:10 2022 +0000

    Bump version to 423

commit 4906b64
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Oct 19 00:40:18 2022 +0000

    Update Alpine repositories

commit 3b82191
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Oct 16 06:14:06 2022 +0000

    Bump version to 422

commit f76e46a
Author: Jason Conway <jpc@jasonconway.dev>
Date:   Sat Oct 15 20:35:03 2022 -0500

    Update golden file

commit 8146bf6
Author: Jason Conway <jpc@jasonconway.dev>
Date:   Sat Oct 15 20:33:25 2022 -0500

    Expand qemu-test and add tests for new instructions

commit 5bd020b
Author: Jason Conway <jpc@jasonconway.dev>
Date:   Sat Oct 15 20:26:38 2022 -0500

    legalize instructions

    Add mov instructions for packed floating-point values; single-precision min, max, and sqrt; movntq and movntdq

commit 5e5263b
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Oct 16 00:41:43 2022 +0000

    Update Alpine repositories

commit 410615e
Author: Mike Miller <emkey1@oneopa.com>
Date:   Sat Oct 15 14:54:36 2022 -0700

    Checkpoint, build 321 I think

commit 36e181d
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Oct 11 06:25:17 2022 +0000

    Bump version to 421

commit f365fa8
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Oct 11 00:36:35 2022 +0000

    Update Alpine repositories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gipnomag gipnomag gipnomag approved these changes

@zar839 zar839 zar839 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jason-conway @gipnomag @zar839