Add macros to check for correct signal_emit params #954
Conversation
This allows the compiler to throw an error if the params argument doesn't match the number of params provided after.
|
will this cause any issues on solaris builds? |
|
if we cannot answer that, could we first commit 2df8357 |
|
Neat. |
|
Hm, turning a public symbol into a macro is at least ABI breaking, not sure if it counts as API breaking too. |
|
It's only API breaking if you're dumb enough to try to use the symbol in any other way besides calling it. But yes, it is ABI breaking. About to go to sleep, will bump the ABI number later (or somebody else can push that commit to my branch) |
|
we might be able to solve this better by using a signal registry and typed emissions |
|
The current type system we have, for things like IS_SERVER, is a not-insignificant chunk of CPU time in my playback tests, which is why I've talked about getting rid of it on IRC. Also, that is a runtime check, whereas this is a compile-time check. |
This allows the compiler to throw an error if the params argument doesn't match the number of params provided after. Also fixes the issues the macros detected.