Fix several darwin related warnings #1487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, it is not possible to build git master on Darwin, as seen in several issues reported previously. This commit fixes that issues, by initializing two variables to NULL. I have no idea, why this solves the linking error, as to my knowledge, global variables do not need to be initialized.
This commit removes the `const` qualifier from certain member fields, as the Darwin version of several `<term.h>` related functions only accept a `char *` rather than a `const char *`, thereby resulting in dozens of compiler warnings.
This commit includes the real `tpus(3)` function from the appropriate `term.h` header file, if found. This commit is necessary to fix a compiler warning on Darwin.
|
I fear that fixing compiler warnings on one side may cause compiler warnings on another side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based upon #1485.
Please read the commit messages for more details.