Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds print_topic_on_join and print_url_on_join booleans under lookandfeel #1468

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

titibandit
Copy link

@titibandit titibandit commented Apr 21, 2023

Suppresses the automatic printing of a channel's topic and/or url upon joining.
Right now, changing print_topic_on_join using /set won't register the change before a restart, since changing the variable doesn't add or remove the function call that already attached to the signals.

It's a pretty simplistic patch in its current state.

@titibandit titibandit changed the title adds print_topic_on_join boolean under lookandfeel adds print_topic_on_join and print_url_on_join booleans under lookandfeel Apr 21, 2023
@titibandit
Copy link
Author

Does anything speaks againt merging this PR?

@ailin-nemui
Copy link
Contributor

hi, I'm sorry for letting your patch hang here like this. Many thanks for the contribution.

In its current state, it is too simplistic to be admitted into Irssi as is (it needs to work without restart and unbinding of signals) and I also need to verify if these numerics are only used on join or maybe also come from some other commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants