Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in case of 204 No Content response do not parse body as it might be a… #73

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

in case of 204 No Content response do not parse body as it might be a… #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 11 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function request(options, callback) {
else if(typeof options.body !== 'string')
options.body = JSON.stringify(options.body)
}

//BEGIN QS Hack
var serialize = function(obj) {
var str = [];
Expand All @@ -88,7 +88,7 @@ function request(options, callback) {
}
return str.join("&");
}

if(options.qs){
var qs = (typeof options.qs == 'string')? options.qs : serialize(options.qs);
if(options.uri.indexOf('?') !== -1){ //no get params
Expand All @@ -98,7 +98,7 @@ function request(options, callback) {
}
}
//END QS Hack

//BEGIN FORM Hack
var multipart = function(obj) {
//todo: support file type (useful?)
Expand All @@ -121,7 +121,7 @@ function request(options, callback) {
result.type = 'multipart/form-data; boundary='+result.boundry;
return result;
}

if(options.form){
if(typeof options.form == 'string') throw('form name unsupported');
if(options.method === 'POST'){
Expand Down Expand Up @@ -271,7 +271,13 @@ function run_xhr(options) {
xhr.body = xhr.responseText
if(options.json) {
try { xhr.body = JSON.parse(xhr.responseText) }
catch (er) { return options.callback(er, xhr) }
catch (er) {
if (xhr.statusCode !== 204) {
return options.callback(er, xhr)
} else {
xhr.body = {}
}
}
}

options.callback(null, xhr, xhr.body)
Expand Down