Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t calllback with JSON parse error #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don’t calllback with JSON parse error #28

wants to merge 1 commit into from

Commits on May 14, 2014

  1. Don’t error on JSON parse error 

    It should be up to the caller to decide if a non-JSON body is actually
an error state.

For example: you make a request where you expect a JSON response, but
instead you get 204 No Content.  It should be up to your application
to decide what that means.
    Robert committed May 14, 2014
    Configuration menu
    Copy the full SHA
    64f40de View commit details
    Browse the repository at this point in the history