Add mywallbox Adapter to latest

[SKB-CGN]

Adapter for Cloud based Wallboxes like Pulsar or Pulsar Plus

[Apollon77]

Hi, thank you for your adapter.

Is the adapter for Pulsar Wallboxes only? Then "Wallbox" as name is too generic in my eyes ... or do you pan to add more other such? Could you please rename it to pulsar-wallbox or such?

[SKB-CGN]

Hi, thank you for your adapter.

Is the adapter for Pulsar Wallboxes only? Then "Wallbox" as name is too generic in my eyes ... or do you pan to add more other such? Could you please rename it to pulsar-wallbox or such?

The Company is named "Wallbox" therefore i choosed this name.

[Apollon77]

wow ... puuhh ... a company name which matches a "in the meantime commodoty name of a device type" :-( I will discuss it in core team...
But I hope you also understand my point of view?

[SKB-CGN]

Sure, understand it. Never mind. They even own www.wallbox.com as their domain.
So its most common name for product and company ;)

Could you do the checks needed for the adapter in the meantime? Thanks beforehand!

[SKB-CGN]

Hi,
do we have some news here?

[Apollon77]

Yes, we discussed yesterday. WOuld it be an issue torename tzo "my-wallbox" so we match the name of that cloud servcie you connect to?

Additionally please state in the readme exactly that it is for Wallboxes from company "wallbox" or such ... right now also the Readme could be easiely read "works for all wallboxes". The same for io-package title/tileLang and desc fields please.

This is a special case, but we want to avoid user confusion.

Additionally please adjust the links in the repo file to use raw.githubusercontent.com like the others ... github.com is not a CDN service ...

Thnak you very much for your understanding and support on this

[SKB-CGN]

Hi,
would you please check the things again.

I have updated the name to My-Wallbox and changed (hopefully) all necessary dependencies and files.

Thank you!

[Apollon77]

I will do the adapter review in the next days ...

[SKB-CGN]

Great, but now i have the problem, that the adapter is not working anymore ... i do not know, whats going on.

[Apollon77]

Hm ... data on github looks fine ... what error you get?

[SKB-CGN]

The adapter is not doing anything. No commands running, no Interval is working. Nothing.

Even not able to change to debug to see some output.

[Apollon77]

Code wise looks good ... also github actionsstart tghe adapter ... how you test locally?

[SKB-CGN]

i created the adapter with adapter creator and everytime i change the code, i do iobroker upload mywallbox

[Apollon77]

but you also reinstalled the adapter after that namechange completely?

[SKB-CGN]

Holy bible. I missed an error-handling. Will fix that shortly.

[SKB-CGN]

Now its working again. Thanks for waiting.

[SKB-CGN]

@Apollon77 Do we have some news here? :)

[Apollon77]

Yes, after vacation, wasn't able to do it before

[SKB-CGN]

Can someone please tell me, how "ioBroker.my-wallbox" can be removed here? I needed to change the name and the check always goes through my-wallbox either instead of only using mywallbox.

Thank you!

[Apollon77]

All good ... the checker only checks the initial repo file change ... so clean would be new PR ... but in this case "known", so all fine

[SKB-CGN]

Ok and all things are good now?

[Apollon77]

Hi,
here my review comments:

• please sort in the entry in this PR alphabetically
• please fix that link https://github.com/SKB-CGN/ioBroker.mywallbox/blob/main/io-package.json#L131 (blob is too much)
• please also add an emoty "password" field in native https://github.com/SKB-CGN/ioBroker.mywallbox/blob/main/io-package.json#L151 as default value
• Please add a "common.globalDependencies with admin >= 4.0.9 to io-package because you use the automatic encryption
• you configured the automatic encryption but still have code in admin to encrypt passwords and to decrypt in main.js ... you you encrypt it twice right now ... Please remove https://github.com/SKB-CGN/ioBroker.mywallbox/blob/main/admin/index_m.html#L63 and the main.js code (would be breaking for all current users)
• Note: Using intervals for external server communication is not ideal (https://github.com/SKB-CGN/ioBroker.mywallbox/blob/d3e6a7543c1eb7ee85660d31b14672761cf4e28a/main.js#L444) ... can be done but could generate issues- seee infos in best practices
• you should set a timeout for the external communication which is always lower then your interval (or not use an interval at all - see above)
• Please check roles - e.g. https://github.com/SKB-CGN/ioBroker.mywallbox/blob/d3e6a7543c1eb7ee85660d31b14672761cf4e28a/main.js#L806 ... an indicator is defined as boolean red-only and not for numbers, see Role definitions in https://github.com/ioBroker/ioBroker/blob/master/doc/STATE_ROLES.md

Thank you for checking and adjusting,

Ingo

[github-actions]

Automated adapter checker

blob

👍 No errors found

ioBroker.my-wallbox

• ❗ [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.my-wallbox". Now is "iobroker.mywallbox"
• ❗ [E103] "common.name" in io-package.json must be equal to "my-wallbox'". Now is mywallbox
• ❗ [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.my-wallbox
• ❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2024 SKB-CGN info@skb-web.de" at the end of README.md
• ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2024 SKB-CGN info@skb-web.de" at the start of LICENSE
• 👀 [W171] "common.title" is deprecated in io-package.json
• 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W202] Version of package.json (1.0.0) doesn't match latest version on NPM ({"_id":"iobroker.my-wallbox","name":"iobroker.my-wallbox","time":{"created":"2022-08-17T08:16:34.223Z","0.0.17":"2022-08-17T08:16:34.533Z","modified":"2022-08-17T09:32:02.229Z","unpublished":{"time":"2022-08-17T09:32:02.229Z","versions":["0.0.17"]}}})
• 👀 [W400] Cannot find "my-wallbox" in latest repository

ioBroker.mywallbox

• ❗ [E605] No actual year found in copyright. Please add "Copyright (c) 2024 SKB-CGN info@skb-web.de" at the end of README.md
• ❗ [E701] No actual year found in LICENSE. Please add "Copyright (c) 2024 SKB-CGN info@skb-web.de" at the start of LICENSE
• 👀 [W171] "common.title" is deprecated in io-package.json
• 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W400] Cannot find "mywallbox" in latest repository

Add comment "RE-CHECK!" to start check anew

[SKB-CGN]

Hi,
i think the Adapter is ready to be added to the repo.

Please let me know!

[mcm1957]

RE-CHECK!

[github-actions]

Automated adapter checker

blob

-

👍 No errors found

ioBroker.my-wallbox

-

• ❗ [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.my-wallbox". Now is "iobroker.mywallbox"
• ❗ [E103] "common.name" in io-package.json must be equal to "my-wallbox'". Now is mywallbox
• ❗ [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.my-wallbox
• 👀 [W171] "common.title" is deprecated in io-package.json
• 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W202] Version of package.json (1.1.0) doesn't match latest version on NPM ({"_id":"iobroker.my-wallbox","name":"iobroker.my-wallbox","time":{"created":"2022-08-17T08:16:34.223Z","0.0.17":"2022-08-17T08:16:34.533Z","modified":"2022-08-17T09:32:02.229Z","unpublished":{"time":"2022-08-17T09:32:02.229Z","versions":["0.0.17"]}}})
• 👀 [W400] Cannot find "my-wallbox" in latest repository

ioBroker.mywallbox

-

👍 No errors found

• 👀 [W171] "common.title" is deprecated in io-package.json
• 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W400] Cannot find "mywallbox" in latest repository

Add comment "RE-CHECK!" to start check anew

[mcm1957]

Sorry to respond late. I must confess that I missed this PR (as it so old and the last one still ative in the backlog)
SORRY.

In addition some more Issues have been detected or are still open

• dependencies are incomplete

  You ear eusing axios, but axios is not include in adapter dependencies; use 'npm i axios' to add axios to the list of dependencies. Do not forget to commit package-loc.json too. This will require a ne release to as package.json is includes into npm packge.

https://github.com/SKB-CGN/ioBroker.mywallbox/blob/4014eef08357f294a66b2ba88840858ae2fecb91/main.js#L12C32-L13C1
https://github.com/SKB-CGN/ioBroker.mywallbox/blob/4014eef08357f294a66b2ba88840858ae2fecb91/package.json#L23

• consider automatic deploy (suggestion only - NON blocking!)

  I suggest to consider enabling automatic deploy to npm for new releases:
  https://github.com/SKB-CGN/ioBroker.mywallbox/blob/4014eef08357f294a66b2ba88840858ae2fecb91/.github/workflows/test-and-release.yml#L58
  But note, that this is only asuggestion and is not blocking !

• reevaluate state roles - still seems to be open

  Only the values specified here (https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md) may be used as state roles. Do not invent new names as this might disturb the functionalyity of other adapters or vis.

  In addition the roles MUST match the read/write functionality. As an example a role value.* requires that the state is a readable state. Input states (write only) should have roles like level.*. Please read the description carefully. States with role 'button' should (must) have attribute 'common.read=false' set. A button ( "Taster" in german only triggers when you press but else has no state), so it should also be not readable. This is also like HomeMatic does it. A switch has clear states true or false and so can be read. (see i.e. https://github.com/SKB-CGN/ioBroker.mywallbox/blob/04d181677262da0a963fb2486beec7e53ec0e361/main.js#L942)

  Roles are important for the type detector to work. So avoid general roles (like state or text) whenever a specific role exissts.

  Most states are created with role state while more specific roles exsists for sure, i.e.

  • lastSyncDT is most likely some date timestamp i.e. role
  • role indicator requires a boolen state (https://github.com/ioBroker/ioBroker.docs/blob/master/docs/en/dev/stateroles.md#indicators-boolean-read-only)
    so powerSharingStatus euther needs type boolean or anopther role (i.e. value)
  • software.currentVersion should be info.firmwarversion
  • maxChgCurrent is for sure a currentvalue, so use i.e. value.current
  • ... please check all rolues and use specific roles whenever tehy exist.

• several files at ./lib are copied from iobroker.repositories

  Please delete the files not belonging to your adapter

• possibly unused variables

  Looks adapterItervals.controlCharger and changeChargerData are not used except when trying to canel them. Please remove them if I did not miss something

The following remarks by Apollon77 are still not solved too:

• please sort in the entry in this PR alphabetically

Please let me/us know if you encounter any problem and which timefram you expect to fix the mentionend issues.

reminder 15.3.2024

[SKB-CGN]

Hi,
can we shortly pause this topic?
I will be on vacation the next weeks and after that, i will try, to fix all the things.
Please pause till middle of april.

Thank you!

[mcm1957]

OK
No problem
Have some nice vacation.

reminder 1.6.2024