There is an implementation setStateChanged/setStateChangedAsync based on adapter.setForeignStateChanged.
#1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ased on `adapter.setForeignStateChanged`. Notise: looks like the `adapter.setForeignStateChanged` use the `state.ts` value to compare, as result, it always be changed. https://github.com/ioBroker/ioBroker.js-controller/blob/5f3c5bf6099dd086b20dcd9daf67e17ac5bcb31f/packages/adapter/src/lib/adapter/adapter.ts#L8000 There are two possibility to solve - to request change in ioBroker.js-controller, or make own comparison of new and old state attributes.
…ased on `adapter.setForeignStateChanged`. - fix the `state.ts` issue described in comments to the "Feature: function setState / setStateAsync only if not equal with oldState (setStateChanged)" ioBroker#1507
- finally fixed the caching "issue".
|
Please add some integration tests to check if everything works as expected (since those changes are very complex) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ased on `adapter.setForeignStateChanged`. - integration tests for `setStateChanged` is added.
Sure. |
…ased on `adapter.setForeignStateChanged`. - sync `javascript.md` with upstream master, to resolve conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notise: looks like the
adapter.setForeignStateChangeduse thestate.tsvalue to compare, as result, it always be changed.https://github.com/ioBroker/ioBroker.js-controller/blob/5f3c5bf6099dd086b20dcd9daf67e17ac5bcb31f/packages/adapter/src/lib/adapter/adapter.ts#L8000
There are two possibility to solve - to request change in ioBroker.js-controller, or make own comparison of new and old state attributes.