Replace internal types with bundled globals file #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the types inlined in
SolInternalTypeFactorywith a bundled.solfile that is loaded through the PSI system. This allows references to globals to have a destination, essentially providing docs in-process.Example:
Jumping to
keccak256in this file...Displays the following file
In addition, syntax highlighting now uses the properties from the global scope in order to highlight globals, meaning they no longer need to be hard-coded in the annotator.
I've added all of the globals from the solidity docs that I could find, including the array and address scopes. This seems to work pretty well so far, but more extensive testing is probably still needed.
TODO