-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Gradle build config #10843
Draft
aSemy
wants to merge
12
commits into
intellij-rust:master
Choose a base branch
from
aSemy:experiments/refactor-gradle-build-config
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor Gradle build config #10843
aSemy
wants to merge
12
commits into
intellij-rust:master
from
aSemy:experiments/refactor-gradle-build-config
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use test-fixtures for sharing test utilities - create convention plugins for sharing build config between subprojects - set up dependencies catalog - move subproject specific configuration into each subproject's build file - move build properties into single extension, IntellijRustBuildProperties.kt - add descriptions to subprojects - use typesafe project accessors - update sharing of kotlin source files to use Configuration-based sharing
- register inputs/outputs correctly, so Gradle can do up-to-date checks - use services in preparation for Configuration Cache compatibility
aSemy
force-pushed
the
experiments/refactor-gradle-build-config
branch
from
September 6, 2023 14:55
b287f8c
to
4eeb8e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt at #10841
I thought I'd make a PR to demonstrate what #10841 would end up looking like :). Some of this can be split up into smaller PRs
This covers most of the improvements in #10841
Summary
UpdateCargoOptions
, for generatingCargoOptions.kt
(moving it out of the build script helps keep the build logic more organised, and creating a specific task makes it easier to use the Gradle API as intended)todo
gradle-231.properties
andgradle-232.properties
files are ignored - I've got an idea of how to make this better...Result
build.gradle.kts
is smaller and more manageable./gradle/libs.versions.toml
Changelog
changelog: refactored Gradle build config (no functional changes)