ANN: Add support for E0128 #10313
Open
ANN: Add support for E0128 #10313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-sz
force-pushed
the
konrad-sz/E0128
branch
from
67db6fd
to
b56076f
Compare
konrad-sz
force-pushed
the
konrad-sz/E0128
branch
from
b56076f
to
9285e06
Compare
vlad20012
reviewed
Apr 23, 2023
vlad20012
reviewed
May 1, 2023
Comment on lines
1979
to
1990
| private fun findTypeParameterOwner(path: RsPath): RsTypeParameter? { | ||
| var parent = path.parent | ||
| while (parent is RsTypeArgumentList || parent is RsPathType || parent is RsPath) { | ||
| parent = parent.parent | ||
| } | ||
|
|
||
| return if (parent is RsTypeParameter) { | ||
| parent | ||
| } else { | ||
| null | ||
| } | ||
| } |
There was a problem hiding this comment.
Why not path.contextOfType<RsPathType>?.owner?.context as? RsTypeParameter ?
Comment on lines
1607
to
1608
| typeParameter.parent.let { | ||
| if(it is RsTypeParameterList) { |
There was a problem hiding this comment.
I suppose it would look better without let :)
|
|
||
| typeParameter.parent.let { | ||
| if(it is RsTypeParameterList) { | ||
| val parameterIndex = it.typeParameterList.indexOf(typeParameter).takeIf { it != -1 } ?: return |
There was a problem hiding this comment.
Let extrect it.typeParameterList to a variable since it is used twice
vlad20012
reviewed
May 4, 2023
Comment on lines
+1607
to
+1547
| val typeParameterList = (typeParameter.parent as? RsTypeParameterList)?.typeParameterList ?: return | ||
|
|
||
| val parameterIndex = typeParameterList.indexOf(typeParameter).takeIf { it != -1 } ?: return | ||
| val referencedParameterIndex = typeParameterList.indexOf(resolved).takeIf { it != -1 } ?: return | ||
| if (parameterIndex < referencedParameterIndex) { |
There was a problem hiding this comment.
Seems good! But this code can be further simplified:
Suggested change
| val typeParameterList = (typeParameter.parent as? RsTypeParameterList)?.typeParameterList ?: return | |
| val parameterIndex = typeParameterList.indexOf(typeParameter).takeIf { it != -1 } ?: return | |
| val referencedParameterIndex = typeParameterList.indexOf(resolved).takeIf { it != -1 } ?: return | |
| if (parameterIndex < referencedParameterIndex) { | |
| if (resolved in typeParameter.rightSiblings) { |
vlad20012
reviewed
May 4, 2023
Comment on lines
1605
to
1541
| val resolved = path.reference?.resolve() ?: return | ||
| val typeParameter = path.contextOfType<RsPathType>()?.owner?.context as? RsTypeParameter ?: return |
There was a problem hiding this comment.
I'd also swapped these lines because the second line will more likely lead to early return
Suggested change
| val resolved = path.reference?.resolve() ?: return | |
| val typeParameter = path.contextOfType<RsPathType>()?.owner?.context as? RsTypeParameter ?: return | |
| val typeParameter = path.contextOfType<RsPathType>()?.owner?.context as? RsTypeParameter ?: return | |
| val resolved = path.reference?.resolve() ?: return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Add support for E0128