Remove usages of DFile where DPsiFile is enough #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etienne02
force-pushed
the
use-dpsifile-instead-of-dfile
branch
from
758968b
to
605a8d8
Compare
added 2 commits
May 14, 2024 19:05
Using the interface is better to decouple code and allow a future split into multiple submodules (where implementation will be in another module from api).
This shows that it’s a PsiFile and also that’s the implementation of the interface of the DPsiFile interface.
etienne02
force-pushed
the
use-dpsifile-instead-of-dfile
branch
from
605a8d8
to
e718cc9
Compare
SingingBush
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also rename DFile to DPsiFileImpl
Using the interface is generally better as it allow to decouple with the implementation, and will allow a future split of api and implementation being separated.