Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved code completion using DCD #339

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Scellow
Copy link
Contributor

@Scellow Scellow commented Dec 30, 2017

Related: #318

Do not merge yet, this will take some time before it is perfect :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 44.734% when pulling 72d7b91 on Scellow:dcd_rework into a20d6b6 on intellij-dlanguage:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 44.751% when pulling 1b3b245 on Scellow:dcd_rework into a20d6b6 on intellij-dlanguage:develop.

@pirocks
Copy link
Collaborator

pirocks commented Jan 24, 2018

Need any help/advice/suggestions? If your ready to merge, just say so.

@Scellow
Copy link
Contributor Author

Scellow commented Jan 26, 2018

I'm currently working on implementing workspace-d instead of manually managing dcd-client/server

https://github.com/Pure-D/workspace-d

I'm quite busy right now but i think this will be ready by the end of this month

@pirocks
Copy link
Collaborator

pirocks commented Feb 25, 2018

There have recently been changes to the settings ui which could cause issues merging this PR. Just a heads up.

@sysint64
Copy link
Member

sysint64 commented Feb 26, 2018

I'm currently working on implementing workspace-d instead of manually managing dcd-client/server

it may be better to split tasks and make two pull request? first with new improvements with completion and second - implementing workspace-d?

Copy link
Collaborator

@pirocks pirocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that these comments also apply to #400. One question I have is does this PR(and #400), completely remove support for dcd, meaning that all future releases will not include dcd support?

} else if (element is DLanguageVariableDeclaration)
{
"Variable"
} else
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider handling: Constructors, Labels(goto label;), Named import binds, Struct Declarations.

} else if (element is DlangCatch)
{
"Catch"
} else if (element is DLanguageVariableDeclaration)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable declarations are split into two categories, specifically, AutoDeclarationPart and Declarator. Use element.parent is DLanguageVariableDeclaration for this.

process = processBuilder.start()
process?.let {
err = DataInputStream(it.errorStream)
input = DataInputStream(it.inputStream)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can start the process asynchronously with:

ProgressManager.getInstance().runProcessWithProgressAsynchronously(processStartUpTask,BackgroundableProcessIndicator(processStartUpTask))```

@SingingBush
Copy link
Member

@Scellow there's not been an update on this for a while. Is it still ongoing? If so could you please rebase against the develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants