-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved code completion using DCD #339
base: develop
Are you sure you want to change the base?
Conversation
Need any help/advice/suggestions? If your ready to merge, just say so. |
I'm currently working on implementing workspace-d instead of manually managing dcd-client/server https://github.com/Pure-D/workspace-d I'm quite busy right now but i think this will be ready by the end of this month |
There have recently been changes to the settings ui which could cause issues merging this PR. Just a heads up. |
it may be better to split tasks and make two pull request? first with new improvements with completion and second - implementing workspace-d? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} else if (element is DLanguageVariableDeclaration) | ||
{ | ||
"Variable" | ||
} else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider handling: Constructors, Labels(goto label;
), Named import binds, Struct Declarations.
} else if (element is DlangCatch) | ||
{ | ||
"Catch" | ||
} else if (element is DLanguageVariableDeclaration) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variable declarations are split into two categories, specifically, AutoDeclarationPart and Declarator. Use element.parent is DLanguageVariableDeclaration
for this.
process = processBuilder.start() | ||
process?.let { | ||
err = DataInputStream(it.errorStream) | ||
input = DataInputStream(it.inputStream) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can start the process asynchronously with:
ProgressManager.getInstance().runProcessWithProgressAsynchronously(processStartUpTask,BackgroundableProcessIndicator(processStartUpTask))```
@Scellow there's not been an update on this for a while. Is it still ongoing? If so could you please rebase against the develop branch |
Related: #318
Do not merge yet, this will take some time before it is perfect :)