Fix random corruption issue #1048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvrogozh
suggested changes
Sep 17, 2020
There was a problem hiding this comment.
This looks to be hack WA. How playing with alignments could fix such an issue? This basically means that you have some place in the driver which copies one struct to another via something like memcpy assuming that they have same fields - which is wrong behavior. Or there is place in the driver which somehow looks into struct padding area and makes some conclusions from that - this is wrong as well. In any case it seems that issue is not actually root caused.
@mgonchar, @onabiull, @dmitryermilov : FYI.
Set struct alignment for DDI_MEDIA_SURFACE and DDI_MEDIA_BUFFER which will fix random corruption issue. Fixed #1028
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set struct alignment for DDI_MEDIA_SURFACE and DDI_MEDIA_BUFFER which will fix random corruption issue. Fixed #1028