[SYCL] Get pointer should not be called on host for local accessors #13747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdelan
changed the title
Local accessors only have their memory allocated when a kernel starts executing. Any pointer that refers to local memory on host before kernel execution has begun is therefore invalid.
hdelan
force-pushed
the
local-acc-get-pointer
branch
from
f91bcd8
to
dc296e2
Compare
Remove test for get pointer for local accessors on the host.
|
Friendly ping @cperkinsintel @intel/llvm-reviewers-runtime |
uditagarwal97
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local accessors only have their memory allocated on device when a kernel starts executing. Any pointer that refers to local memory on host before kernel execution has begun is therefore invalid.
Table 78 in
https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#_interface_for_local_accessors