[SYCL][Graph] Export missing graph node symbols #13744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The symbols for templated methods `node::update_range()` and `node::update_nd_range()` were not having their symbols exported on Windows DLLs. Leading to link errors when running clang in the Graph E2E tests `Update/update_nd_range.cpp` and `Update/update_range.cpp` Fixed by adding `__SYCL_EXPORT` to the templated specializations are recommended by the [__SYCL_EXPORT Macro documentation](https://intel.github.io/llvm-docs/developer/ABIPolicyGuide.html#sycl-export-macro)
reble
approved these changes
May 10, 2024
bso-intel
approved these changes
May 10, 2024
Bensuo
approved these changes
May 13, 2024
|
@intel/llvm-gatekeepers This is good to merge, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symbols for templated methods
node::update_range()andnode::update_nd_range()were not having their symbols exported on Windows DLLs. Leading to link errors when running clang in the Graph E2E testsUpdate/update_nd_range.cppandUpdate/update_range.cppFixed by adding
__SYCL_EXPORTto the templated specializations are recommended by the __SYCL_EXPORT Macro documentationAlso removed duplicate forward declaration of
command_graphfromgraph.hpp. It is already forward declared earlier on in the file on line 43.