[LIBCLC] Correctly set up llvm-spirv and libclc-remangler #13743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @frasercrmck |
npmiller
approved these changes
May 10, 2024
jchlanda
force-pushed
the
jakub/libclc_customs_fix
branch
from
a8271ce
to
df91e5d
Compare
Also only search for llvm-spirv if it has not been set in the custom tools path.
|
@frasercrmck are you ok with this going in? |
frasercrmck
approved these changes
May 21, 2024
There was a problem hiding this comment.
Makes sense to me.
For a bit of context, when I redid the CMake stuff I noticed that the custom tools path wasn't picking up on either of these two tools even though it looked like it was wanting to import them. So I think I preserved the old behaviour to avoid any nasty surprises, rather than the intended behaviour. Adding the error message without seeing that it would always trip was my fault, sorry!
|
@intel/llvm-gatekeepers this is ready to go. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customs dirs path was asserting on the existence of
llvm-spirvandlibclc-remangler, however those tools have not been set up.Also only search for llvm-spirv if it has not been set in the custom tools path.