-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] [Joint Matrix] Modularized tests #13730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that tests in XMX8 folder were not changed, while some .hpp files which are used for XMX8 were changed. Most likely it will cause compilation failures for XMX8 tests. Please, update tests in that folder as well accordingly.
Also other comments need to be addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 tests specific for CPU are not running in pre-check-in testing. Could you run them locally to verify your changes or remove these 2 tests from PR?
Why did you remove the changes from the CPU tests? |
@dkhaldi - I removed the changes to the CPU tests because it was not trivial to convert the CPU centric |
@intel/llvm-gatekeepers Ready to merge |
This is part 1 of 2 to improve reuse of common functions in the Joint Matrix test set. This changes focuses on removing functions, aliases and types from individual tests and relying on them being present in
common.hpp
.