[SYCL][Doc] Extension spec for "work_group_memory" #13725
+607
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a proposed extension specification for `work_group_memory`, a lighter weight API to allocate device local memory for an nd-range kernel.
Add a list of restrictions that, when followed, provide a guarantee that a kernel written in the free-function kernel syntax can be launched directly via Level Zero or OpenCL.
bsochack
reviewed
May 13, 2024
| when the kernel adheres to the following restrictions: | ||
|
|
||
| * The kernel is written in the free function kernel syntax; | ||
| * The kernel function is declared as `extern "C"`; and |
There was a problem hiding this comment.
Is "extern C" disabling i.e. dead arg elimination optimization?
There was a problem hiding this comment.
Good point. No, you need to disable this via the -fno-sycl-dead-args-optimization option. I added this to the list of restrictions in a885e42.
| _Returns:_ A `multi_ptr` to the underlying device local memory object. | ||
|
|
||
|
|
||
| == Examples |
There was a problem hiding this comment.
Can you please provide an example of work_group_memory with free function kernel?
Add example using `work_group_memory` in free function kernel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a proposed extension specification for
work_group_memory, alighter weight API to allocate device local memory for an nd-range
kernel.
Also related, add a list of restrictions that, when followed, provide a
guarantee that a kernel written in the free-function kernel syntax can
be launched directly via Level Zero or OpenCL.