encode segmentation map refine #744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -666,7 +666,8 @@ typedef struct _VAEncPictureParameterBufferAV1 { | |||
| * 0: 16x16 block size, default value; | |||
| * 1: 32x32 block size; | |||
| * 2: 64x64 block size; | |||
| * 3: 8x8 block size. | |||
| * 3: 8x8 block size; | |||
| * 4: 4x4 block size. | |||
There was a problem hiding this comment.
any value is ok? or backend driver only accept part of them? if so , may need a capability attributes
There was a problem hiding this comment.
Av1 does have a caps report for it. https://github.com/intel/libva/blob/02eed8a57faadcd7f0e5e999723286ed160bd2bd/va/va_enc_av1.h#L154C18-L154C47
This change in comment is for interface completeness. In av1 spec, 4x4 block is allowed.
From av1 spec: Segmentation map
A 3-bit number containing the segment affiliation for each 4x4 block in the image.
Signed-off-by: Yao, Leyu <leyu.yao@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.