Clarify the usage of flag VA_PROC_PIPELINE_FAST. #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeJunyan
reviewed
Aug 2, 2023
Signed-off-by: Furong Zhang <furong.zhang@intel.com>
FurongZhang
force-pushed
the
pipeline_fast
branch
from
b6cf2b2
to
8c30a54
Compare
xhaihao
reviewed
Aug 7, 2023
| * Regarding the usage of this flag, there are some filter properties in vaapi such as | ||
| * VA_FILTER_SCALING_XXX, when VA_PROC_PIPELINE_FAST is combined with these properties, | ||
| * the backend implementation should honor VA_PROC_PIPELINE_FAST which means this flag | ||
| * could change the filter properties implicitly for better performance. |
There was a problem hiding this comment.
Does it mean VA_FILTER_SCALING_XXX won't take effects if VA_PROC_PIPELINE_FAST is set ? How does a user know VA_PROC_PIPELINE_FAST should be set or not ?
There was a problem hiding this comment.
if VA_PROC_PIPELINE_FAST is set, VA_FILTER_SCALING_XXX will not take effect. If the user wants to get better performance, VA_PROC_PIPELINE_FAST should be set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.