add va_dec_avs & va_dec_avs2 #738
Conversation
|
Hi there, I'm grad to announce that we, Moore Threads, have finished Chinese AVS&AVS2 hwaccel decoding under FFMpeg-VAAPI framework. As mentioned before in #664, all our public products, MTT S10/MTT S50/MTT S80/MTT S2000/... support AVS&AVS+ decoding at max 2K and support AVS2 Main&Main10 decoding at max 8K. This PR is the patches for libva. For FFmpeg implementaion, please refer to I will also submit the corresponding patches to FFMpeg lately. Thanks, |
|
Sorry, our driver is currently not open source.
AVS/AVS2 spec and reference decoder can be retrieved from
http://www.avs.org.cn/index/list?catid=7.
For AVS2, there is an open source decoder, [davs2](
https://github.com/pkuvcl/davs2), implemented by Chinese [Peking
University](https://www.pku.edu.cn/). `davs2` has been integrated into
FFMpeg as a 3rd-party decoder.
Dmitry Rogozhkin ***@***.***> 于2023年7月26日周三 00:44写道：
… ***@***.**** commented on this pull request.
Is there open source driver available which supports AVS and AVS2?
—
Reply to this email directly, view it on GitHub
<#738 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJERSGUQRIDNUIVMNRD2ZTXR7ZXHANCNFSM6AAAAAA2W5SLRE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I am ok to accept the AVS and AVS2 decode interfaces, but how to guarantee the usage? and guarantee the health, looks there are no open source project are using it, and no test application , no test coverage? |
@XinfengZhang Please see intel/libva-utils#346, As mentioned, we also implemented ffmpeg-vaapi decoding for AVS and AVS2. Please see gitgjogh/FFmpeg#1. The PR would be submmitted to FFMpeg devel after this PR being accepted. |
gitgjogh
force-pushed
the
master
branch
2 times, most recently
from
a4d198a
to
620f456
Compare
|
Hi @dvrogozh @XinfengZhang, is this PR still in reviewing? |
see intel/libva#738 [Moore Threads](https://www.mthreads.com) (short for Mthreads) is a Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. , support AVS/AVS+ HW decoding at max 2k resolution. Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
see intel/libva#738 [Moore Threads](https://www.mthreads.com) (short for Mthreads) is a Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. , support AVS2 8bit/10bit HW decoding at max 8k resolution. Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
see intel/libva#738 [Moore Threads](https://www.mthreads.com) (short for Mthreads) is a Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. , support AVS2 8bit/10bit HW decoding at max 8k resolution. Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
see intel/libva#738 [Moore Threads](https://www.mthreads.com) (short for Mthreads) is a Chinese GPU manufacturer. All our products, like MTTS70/MTTS80/.. , support AVS/AVS+ HW decoding at max 2k resolution. Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
see intel/libva#738 Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
Signed-off-by: jianfeng.zheng <jianfeng.zheng@mthreads.com>
| uint16_t fixed_pic_qp_flag : 1; | ||
| uint16_t picture_qp : 6; | ||
| uint16_t loop_filter_disable_flag : 1; | ||
| uint16_t skip_mode_flag_flag : 1; |
There was a problem hiding this comment.
Is skip_mode_flag_flag a typo ? I guess it should be skip_mode_flag.
| DPY2TRACECTX(dpy, context, VA_INVALID_ID); | ||
|
|
||
| switch (type) { | ||
|
|
There was a problem hiding this comment.
Could you add code to dump each field in avs2 buffer ?
| DPY2TRACECTX(dpy, context, VA_INVALID_ID); | ||
|
|
||
| switch (type) { | ||
|
|
There was a problem hiding this comment.
Could you add code to dump each field in avs buffer ?
add VAProfileAVSJizhun and VAProfileAVSGuangdian
add VAProfileAVS2Main and VAProfileAVS2Main10
Signed-off-by: jianfeng.zheng jianfeng.zheng@mthreads.com