Fix race between JIT executing emulated code and another image starting. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More silent corruption due to lack of reentrance. But it's not enough to wrap uc_mem_protect...interrupts can be re-enabled inside JITted code (or really anytime) due to TPL manipulation, so need to hook the EFI_CPU_ARCH_PROTOCOL interrupt manipulation routines. Very much reaching the point where a better JIT needs to be written that doesn't have the reentrancy issues. Tested with ArmVirtPkg running the virtio-net x64 driver + loading another x64 driver from Shell. No longer seeing Mnp/Snp errors due to accessing bogus buffer address. Signed-off-by: Andrei Warkentin <andrei.warkentin@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More silent corruption due to lack of reentrance. But it's not enough to wrap uc_mem_protect...interrupts can be re-enabled inside JITted code (or really anytime) due to TPL manipulation, so need to hook the EFI_CPU_ARCH_PROTOCOL interrupt manipulation routines.
Very much reaching the point where a better JIT needs to be written that doesn't have the reentrancy issues.