Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apply include_all_branches correctly on github_repository template #2237

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Apply include_all_branches correctly on github_repository template #2237

wants to merge 2 commits into from

Conversation

ethanrucinski
Copy link

@ethanrucinski ethanrucinski commented Apr 21, 2024 •
edited

Resolves #2130

Before the change?

  • The repository is created successfully (with all the branches), but during a second apply it will change include_all_branches = false -> true while it was never set to false.

After the change?

  • The repository is created successfully (with all the branches if requested, with the main branch if not), and the provided value for include_all_branches will be applied in state.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: github_repository template include_all_branches = true not applying correctly
1 participant
@ethanrucinski