fix(branch_protection_v3): ignore context when value exists in checks #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jporzucek
changed the title
jporzucek
changed the title
|
@jporzucek Is there an Update on this PR we are waiting heavily on this fix :) @kfcampbell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1701
Before the change?
github_branch_protection_v3flattens all contexts even if they're only configured inchecksand ifcontextsfield is empty inrequired_status_checks.After the change?
If the context is already in checks, it's not parsed into context field.
Pull request checklist
Does this introduce a breaking change?
It doesn't break anything since contexts in
checksare still applied and they'll be applied by GitHub tocontexts.