fix(github_repository_tag_protection): Handle non-existent tag protections in state refresh #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixe
changed the title
…tions in state refresh This commit updates the `resourceGithubRepositoryTagProtectionRead` function to remove tag protections from Terraform's state if they no longer exist in GitHub. This ensures that the state accurately reflects the actual infrastructure and that Terraform will recreate the tag protections if necessary.
kfcampbell
reviewed
Apr 1, 2024
| @@ -98,6 +98,13 @@ func resourceGithubRepositoryTagProtectionRead(d *schema.ResourceData, meta inte | |||
| } | |||
| return err | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Wouldn't we also want to do this if the call to client.Repositories.ListTagProtection 404s? What happened when you tested this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
resourceGithubRepositoryTagProtectionReadfunction to remove tag protections from Terraform's state if they no longer exist in GitHub. This ensures that the state accurately reflects the actual infrastructure and that Terraform will recreate the tag protections if necessary.