fix(data_source_github_organization): update users shape #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the shape of the user objects on the github_organization data source to better match that of the github_user data source. Particularly, exposing the database_id allows this user list to drive some other resources (such as github_repository_environment.reviewers) which require numeric ids without additional github_user data sources. * Adds new node_id property for the GraphQL Node ID * Deprecates id property in favour of using node_id * Adds new database_id property which exposes the integer id of the user Proposal is for v7 to switch id to the integer id, deprecating database_id. v8 would then drop database_id.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the shape of the user objects on the github_organization data source to better match that of the github_user data source.
Particularly, exposing the database_id allows this user list to drive some other resources (such as github_repository_environment.reviewers) which require numeric ids without additional github_user data sources.
Proposal is for v7 to switch id to the integer id, deprecating database_id. v8 would then drop database_id.
Resolves #2207
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!