Bump go-gitub to v60

[nayuta]

Resolves #2187

---

Before the change?

• go-github v57.0.0

After the change?

• go-github v60.0.0
  • Fix code for
    • Turn RequiredStatusChecks Checks and Contexts into pointers google/go-github#3070
    • feat!: Change Hook Config field from map to *HookConfig google/go-github#3073

Pull request checklist

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

• Yes
• No

---

[kfcampbell]

I've resolved the merge conflict, though I'm a little hesitant about the HookConfig changes. The strongly-typed HookConfig struct means we can no longer change 1 to true in the insecureSslStringToBool function. We could remove that line entirely, though that means #2196 would essentially be undone. @EttoreFoti do you have thoughts on this change?

Our docs are pretty vague about this: insecure_ssl says "string or number" next to it. Presumably the string is meant to represent a boolean there, though the docs text mentions only 0 or 1 as valid options.

[EttoreFoti]

I've resolved the merge conflict, though I'm a little hesitant about the HookConfig changes. The strongly-typed HookConfig struct means we can no longer change 1 to true in the insecureSslStringToBool function. We could remove that line entirely, though that means #2196 would essentially be undone. @EttoreFoti do you have thoughts on this change?

Our docs are pretty vague about this: insecure_ssl says "string or number" next to it. Presumably the string is meant to represent a boolean there, though the docs text mentions only 0 or 1 as valid options.

@kfcampbell this is bumping 3 major version of the GitHub client which is core in the provider, all test should be rerun before approving, I'm testing on the issue that was fixed but is unfixed by this PR, I'll create new PR with fixed once done.

[connor-miller-kr]

Any update on this PR?

[Simon-Boyer]

@kfcampbell what is missing for this PR to go forward? Is there anything I can do to help?
I have a project that would need to define rulesets with custom properties and we need go-github v60 to implement this properly in the provider.
@nayuta If you dont have time to work on this right now, could you give me permission to write to your fork so I can give a hand?

[EttoreFoti]

@kfcampbell what is missing for this PR to go forward? Is there anything I can do to help? I have a project that would need to define rulesets with custom properties and we need go-github v60 to implement this properly in the provider. @nayuta If you dont have time to work on this right now, could you give me permission to write to your fork so I can give a hand?

@Simon-Boyer this is breaking a bunch of resources, being an update of the main SDK the full test suite needs to be run to ensure nothing breaks

[nayuta]

@nayuta If you dont have time to work on this right now, could you give me permission to write to your fork so I can give a hand?

@Simon-Boyer I quickly fixed compile errors and invite you to the repo.