fix(resource_github_repository): Create repo from template with visibility to avoid org policy issue #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when creating a repository from a template, it sets the visibility to either `Public` or `Private` and then edits the repo settings later to ensure the visibility is correct. Now it sets the `Visibility` parameter instead.
littlelionking
changed the title
INTERNAL
littlelionking
changed the title
|
I didn't see a way to set |
|
Hi @kfcampbell would I be able to get your thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #925
Before the change?
When creating a repository from a template, it sets the visibility to either
publicorprivateaccording to this bool:And then edits the repo settings later to ensure the visibility is correct.
After the change?
Now it sets the
Visibilityparameter instead, allowing "internal" as an option.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!