Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add delete branch on merge option on datasource github repository #2046

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add delete branch on merge option on datasource github repository #2046

wants to merge 3 commits into from

Conversation

alileza
Copy link

@alileza alileza commented Dec 6, 2023 •
edited

After the change?

Supporting a couple more fields from repository api

  • delete_on_branch_merge
  • get_allow_update_branch

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@alileza alileza marked this pull request as ready for review December 9, 2023 15:36
@alileza alileza marked this pull request as draft December 9, 2023 22:34
@nickfloyd nickfloyd added the Type: Feature New feature or request label Jan 4, 2024
@kfcampbell
Copy link
Member

@alileza feel free to promote this from draft when you're comfortable!

@alileza alileza marked this pull request as ready for review January 10, 2024 12:50
@kfcampbell
Copy link
Member

Would you mind adding checks for these new attributes to github/data_source_github_repository_test.go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alileza @kfcampbell @nickfloyd