canvas_init: Set shell (-s) - suppport limited system user
#2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to
canvas_initso that it can also run under a limited system user account (that does not have a shell by default, or uses/bin/nologinor/bin/false).Currently the service will fail to start if the user does not have a shell set.
As an aside, I would like to see a native systemd service. Even though systemd is ubiquitous these days, it wouldn't be unreasonable to keep this init.d script (e.g. for those few that might wish to use OpenRC - or something else). But a native
canvas_init.servicefile would be preferable. I have personally noticed some weirdness (e.g. the system losing track of it's workers) with the init.d script unless used via systemd (i.e. if you/etc/init.d/canvas_init start, I found on most occasions if I follow that withsystemctl status canvas_initit reports "failed" - but it's actually running).