Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube: Upgrade to v1.33.1 #2841

Merged
merged 2 commits into from
May 16, 2024
Merged

minikube: Upgrade to v1.33.1 #2841

merged 2 commits into from
May 16, 2024

Conversation

mqasimsarfraz
Copy link
Member

@mqasimsarfraz mqasimsarfraz commented May 13, 2024

Upgrade to minikube v1.33.1, see #2833 (comment) for details!

Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some tests on cri-o are failing. Are they related to this PR?

Signed-off-by: Qasim Sarfraz <qasimsarfraz@microsoft.com>
@mqasimsarfraz mqasimsarfraz changed the title minikube: Upgrade to v1.33.0 minikube: Upgrade to v1.33.1 May 16, 2024
Tests on minikube 1.33 with cri-o fail with
"Failed to inspect image "nginx": rpc error: code = Unknown desc = short-name "nginx:latest" did not resolve to an alias and no unqualified-search registries are defined"

Using the full name fixes it.

Signed-off-by: Mauricio Vásquez <mauriciov@microsoft.com>
Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@mqasimsarfraz mqasimsarfraz merged commit feca9f6 into main May 16, 2024
60 checks passed
@mqasimsarfraz mqasimsarfraz deleted the qasim/upgrade-minikube branch May 16, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants