-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go: bump k8s.io/apiextensions-apiserver from 0.29.4 to 0.30.0 #2762
go: bump k8s.io/apiextensions-apiserver from 0.29.4 to 0.30.0 #2762
Conversation
Dependency on #2734 |
5c3ffdc
to
16b0ac4
Compare
@dependabot rebase |
16b0ac4
to
a77ff8d
Compare
2041ee9
to
68faeb6
Compare
I did the glue over the bot commit and Dor's one, as a consequence I will not merge it and prefer to have something else reviewing it. |
go.mod
Outdated
@@ -215,6 +213,6 @@ require ( | |||
sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect | |||
) | |||
|
|||
replace sigs.k8s.io/controller-runtime => sigs.k8s.io/controller-runtime v0.13.1-0.20230315234915-a26de2d610c3 | |||
replace k8s.io/component-base => k8s.io/component-base v0.0.0-20240417101527-62c04b35eff6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this? It compiled and worked fine for me without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nop, it seems needed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose you mean "unneeded", right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I got mixed up!
68faeb6
to
b8c16cd
Compare
Bumps [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) from 0.29.4 to 0.30.0. - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.29.4...v0.30.0) --- updated-dependencies: - dependency-name: k8s.io/apiextensions-apiserver dependency-type: direct:production update-type: version-update:semver-minor ... We also need to bump sigs.k8s.io/controller-runtim to v0.18.0 and add sigs.k8s.io/controller-runtime/pkg/metrics/server for everything to compile. Signed-off-by: dependabot[bot] <support@github.com> Co-developed-by: Dor Serero <dorserero@microsoft.com> Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
b8c16cd
to
0b77060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A newer version of k8s.io/apiextensions-apiserver exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Thank you for the review! |
Bumps k8s.io/apiextensions-apiserver from 0.29.4 to 0.30.0.
Commits
03da840
Update dependencies to v0.30.0 tagcb47ad4
Merge remote-tracking branch 'origin/master' into release-1.306ce7f38
Update x/net for CVE-2023-45288a2f312c
Merge remote-tracking branch 'origin/master' into release-1.30d3649bc
fix test flake caused by not waiting for CRD schema update9624e52
Merge pull request #123732 from serathius/parallel-featureflags24438a9
Merge pull request #123758 from liggitt/protobump916521e
Bump github.com/golang/protobuf v1.5.4, google.golang.org/protobuf v1.33.0fe10ad0
Merge pull request #123405 from cici37/vapGAa853d25
Fix SetFeatureGateDuringTest handling of Parallel testsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)