Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate metadata before running the gadget
#2512 changed the way how the matadata was validated (all validation was almost removed). I think it's still a good idea to validate the whole metadata before processing the gadget and in the same place. This will allow to use the same logic to validate the metadata also when building the gadget.
A deeper discussion will be the role of the metadata now that we agreed to make the macros to define tracers and other mandatory in #2560. Perhaps things like MapName and StructName aren't needed anymore now that those are contained in the eBPF program itself?.
Any thoughts on this?