Restrict option parsers to their compatible options #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 69.46% // Head: 69.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
==========================================
+ Coverage 69.46% 69.59% +0.13%
==========================================
Files 90 90
Lines 5737 5710 -27
==========================================
- Hits 3985 3974 -11
+ Misses 1571 1560 -11
+ Partials 181 176 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hugelgupf
force-pushed
the
restrict
branch
2 times, most recently
from
e8a6e5b
to
ee037bd
Compare
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
…tions RFC 8415 Appendix B and C describe which option codes are allowed in which options, for most of them anyway. Signed-off-by: Chris Koch <chrisko@google.com>
Signed-off-by: Chris Koch <chrisko@google.com>
Tests that for the correct option code, the correct deserialization is applied. Signed-off-by: Chris Koch <chrisko@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other options are still parsed; the option parser does not return an error. Most RFCs that specify options say that one should ignore options specified in places they shouldn't be, rather than take other actions.
This also moves us toward satisfying requests like #395 -- being able to implement lazy parsing.