New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add format command. #55
base: main
Are you sure you want to change the base?
Conversation
This command reads and re-writes (in-place) the metadata files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't expect a "lint" command to modify my source tree by default. It could have a --fix
flag or something that tells it to actually try to fix problems.
app/Foliage/CmdLint.hs
Outdated
want ["lintAction"] | ||
where | ||
cacheDir = "_cache" | ||
opts = shakeOptions {shakeFiles = cacheDir, shakeVerbosity = Verbose} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we share this stuff? Seems like the shake options should pretty much always be the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should. Also we should wire the verbosity to a command line flag. Also I don't like how shake prints messages.
Yes, you are right. Also, what this PR introduces is more a |
This command reads and re-writes (in-place) the metadata files. When applied to CHaP, the result is
It would be better if CHaP's
add-from-github.sh
would use the same formatting but it would be even better to put that functionality inside foliage itself.