Support step.waitForEvent in trace runs
#1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darwin67
requested review from
tonyhb,
djfarrelly,
goodoldneon,
jpwilliams and
BrunoScheufler
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
darwin67
changed the title
step.waitForEventstep.waitForEvent in trace runs
tonyhb
approved these changes
May 15, 2024
jpwilliams
reviewed
May 15, 2024
Comment on lines
+1723
to
+1725
| span.Send() | ||
| defer span.End() | ||
| span.SetAttributes(commonAttrs...) |
There was a problem hiding this comment.
Could we be intensely unlucky here and export the span before the second call to SetAttributes()?
There was a problem hiding this comment.
addressed in #1360
| @@ -2200,6 +2227,7 @@ func (e *executor) handleGeneratorInvokeFunction(ctx context.Context, gen state. | |||
| ), | |||
| ) | |||
| span.Send() | |||
| defer span.End() | |||
There was a problem hiding this comment.
Any reason to do this? span.Send() calls span.End() anyway and we don't add any details to the span later on.
There was a problem hiding this comment.
addressed in #1360
Comment on lines
+2379
to
+2382
| telemetry.WithName(consts.OtelSpanWaitForEvent), | ||
| telemetry.WithTimestamp(now), | ||
| telemetry.WithSpanAttributes( | ||
| attribute.Bool(consts.OtelUserTraceFilterKey, true), |
There was a problem hiding this comment.
This will need some attributes adding to fulfil the resolvers, namely:
- Event name
- Expression
- Expiry time
Comment on lines
+1744
to
+1748
| telemetry.WithSpanAttributes( | ||
| attribute.String(consts.OtelSysStepOpcode, enums.OpcodeWaitForEvent.String()), | ||
| attribute.Int64(consts.OtelSysStepWaitExpires, pause.Expires.Time().UnixMilli()), | ||
| attribute.Bool(consts.OtelSysStepWaitExpired, r.EventID == nil), | ||
| ), |
There was a problem hiding this comment.
We'll also need to add some more info for the resolvers, namely:
- Event name
- Expression
- ID of the found event (if any)
darwin67
added a commit
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add span for showing the step is waiting for an event.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines