Complete pause support in batch handling #1356
Conversation
cdzombak
requested review from
tonyhb,
djfarrelly,
darwin67,
goodoldneon,
jpwilliams and
BrunoScheufler
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Looking good! Should we also update pkg/execution/executor/service.go:321 to use the new RetrieveAndScheduleBatchWithOpts and pkg/execution/runner/runner.go:619 to use the new AppendAndScheduleBatchWithOpts or do you want to do this separately?
Even if this is not relevant in OSS, we might still want to use the new methods so we can phase out the deprecated ones quickly 😄
| AppID uuid.UUID `json:"appID"` | ||
| FunctionID uuid.UUID `json:"fnID"` | ||
| FunctionVersion int `json:"fnV"` | ||
| DeprecatedFunctionPausedAt *time.Time `json:"fpAt,omitempty"` // deprecated |
There was a problem hiding this comment.
How long do we need to keep this around? Just until the old consumers are completely phased out and we run an updated version of pkg/execution/executor/service.go:300 that passes FunctionPausedAt to RetrieveAndScheduleBatchWithOpts?
There was a problem hiding this comment.
Theoretically, I believe we could remove it now, since it's omitempty and no code we've shipped in prod has ever set this field.
For safety, I think we should keep this around until we know all payloads created before this PR is merged have been processed.
✅ Done in bf2cce0. |
Description
This PR allows our batch scheduling logic to take the function's paused_at column into account at the point in time that the batch is being scheduled for imminent execution.
Type of change (choose one)
Checklist