Peek further ahead of queue dynamically #1336
Open
+362
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darwin67
requested review from
tonyhb,
djfarrelly,
goodoldneon,
jpwilliams and
BrunoScheufler
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
darwin67
force-pushed
the
darwin/peek-further-ahead
branch
from
bcef425
to
60d74a5
Compare
darwin67
commented
May 10, 2024
| local partitionKey = KEYS[1] | ||
| local keyGlobalPartitionPtr = KEYS[2] | ||
| local keyShardPartitionPtr = KEYS[3] | ||
| local partitionConcurrencyKey = KEYS[4] |
There was a problem hiding this comment.
should I do anything with the partition concurrency when extending?
darwin67
commented
May 10, 2024
| end | ||
|
|
||
| -- update the lease | ||
| -- NOTE: should `last` also be updated??? |
There was a problem hiding this comment.
should last be updated as well?
considering this is extending the lease, I don't think it does, but would be good to verify.
darwin67
force-pushed
the
darwin/peek-further-ahead
branch
from
60d74a5
to
cf933cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make function queue peek more dynamic, so it guarantees it can at least process X amount of items.
This is useful, especially when concurrency hits and the executor ends up spinning over and over the same queue items. With this change, the queue processor should be able to look further ahead even if there are concurrency limited items backing up the function queue.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines