-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pathCreator in env page #1033
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goodoldneon, what do you think of using https://github.com/lukemorales/next-safe-navigation instead?
I played with it a bit, and it worked great! It also handles search params nicely.
We can still use encodeURIComponent
on it with Zod.
It's maintained by one of the WorkOS devs.
Looks good at a glance! I don't have a preference about what what we use, so long as:
|
After thinking about it a little more, it seems like overkill to add a dependency for the URLs. The existing |
Description
On that env page, replace all
href
template literals withpathCreator
methodsType of change (choose one)
Checklist
Check our Pull Request Guidelines