Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AMD wrappers for runtime and individually compiled templates #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

campadrenalin
Copy link

This work is IN PROGRESS, and probably not adequate for a merge yet! However, it does work quite well for the toy examples I've been working on so far.

TODO:

  • Various syntax cleanup.
  • Consider including a convenience function or script to rebuild a tree of separate AMD modules.
  • Get maintainer feedback. There are places where this code is logically correct, but doesn't "do as the Romans do", for example some changes to quote literals, and using literals at all where the existing code goes through multiple layers of abstraction all the way down to templates.

While I was frustrated by the nondeterministic build process, and worried how that would make the pull request unreadable, Github luckily does not show the large and unnecessary diffs for those files.

@campadrenalin
Copy link
Author

Used the Minilla branch to enable me to do local testing, developed a patch to fix the broken tests (really, the broken behavior in compile_template_content), and applied the patch to this Minilla-free PR branch. Now it passes Travis! Life is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant