Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY out some of the generated code #22

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

pearsonca
Copy link
Collaborator

Trying to troubleshoot some of my generated templates, I was having a lot of trouble seeing through the boilerplate.

So I wrote a short extraction of the setup/try/catch, and added it to the main preamble. The resulting template mappings now have reduced boilerplate. I think there's more opportunity here, and may post additional updates if this is well received.

I had no trouble with the test suite, but only have Chrome available to browse it with.

@pearsonca
Copy link
Collaborator Author

Some oversights corrected after running them down in my application.

@forestbelton
Copy link
Collaborator

i like it. mind massaging the tests to passing status?

@pearsonca
Copy link
Collaborator Author

Yeah, I'm going to go back to working that once I get out from behind some other deadlines.

However, I'm not familiar with using Travis CI, or exactly how the test harness in the project works, so I'm finding it a bit cryptic when trying to get passes. Any documentation people can highlight as a starting point?

@forestbelton
Copy link
Collaborator

hmm, i'm not sure myself. you might want to drop in #jemplate on freenode and talk to @ingydotnet about it

@ingydotnet
Copy link
Owner

I think this is a really good idea.

I've pulled this into branch issue-22. @pearsonca now has push permissions. Just work on the branch and notify me here or on IRC.

As for running the tests, there are at least 2 suites. Use these commands:

$ prove -lv t
$ (cd tests/tjs; make test)

The second suite will show a url. Click it and the tests will run. Both these suites pass on master. The first suite is failing on the issue-22 branch.

I'd be happy to help you work on the tests when you have a chance. Find me on #jemplate.

@pearsonca
Copy link
Collaborator Author

Will do - I've got to finalize a publication this week, but once that's out (or if I need a break), I'll put some attention on this.

@pearsonca
Copy link
Collaborator Author

question - reading through the tests that feed into prove, it seems like what's being tested is, basically, a string match on the generated Jemplate. Is that correct?

I expected something more like a string match between the TT output, and template -> jemplate -> output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants