Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Google Cloud Run resources #3067

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Add support for Google Cloud Run resources #3067

wants to merge 16 commits into from

Conversation

awaismemon26
Copy link

Objective:

Add support for Google Cloud Run resources. Fixes #1361.

Pricing details:

All the pricing details are briefly explained in the Github issue (#1361)

Status:

  • Generated the resource files
  • Updated the internal/resources file
  • Updated the internal/provider/terraform/.../resources file
  • Added usage parameters to infracost-usage-example.yml
  • Added test cases without usage-file
  • Added test cases with usage-file
  • Compared test case output to cloud cost calculator
  • Free tier not included in pricing calculation
  • Created a PR to update "Supported Resources" in the docs

@CLAassistant
Copy link

CLAassistant commented May 9, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@aliscott aliscott self-requested a review May 13, 2024 09:18
@aliscott aliscott self-assigned this May 13, 2024
aliscott
aliscott reviewed May 21, 2024
View reviewed changes
Copy link
Member

@aliscott aliscott left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awaismemon26 thanks this is great 🙏! I only have a few small stylistic suggestions to make this consistent with other resources.

It also looks like this needs a make fmt run on it.

internal/resources/google/cloud_run_service.go Outdated Show resolved Hide resolved
internal/resources/google/cloud_run_service.go Outdated Show resolved Hide resolved
internal/resources/google/cloud_run_service.go Outdated Show resolved Hide resolved
internal/resources/google/cloud_run_service.go Outdated Show resolved Hide resolved
internal/resources/google/cloud_run_service.go Outdated Show resolved Hide resolved
internal/resources/google/cloud_run_v2_job.go Outdated Show resolved Hide resolved
internal/resources/google/cloud_run_v2_job.go Outdated Show resolved Hide resolved
internal/resources/google/cloud_run_v2_service.go Outdated Show resolved Hide resolved
internal/resources/google/cloud_run_v2_service.go Outdated Show resolved Hide resolved
internal/resources/google/cloud_run_v2_service.go Outdated Show resolved Hide resolved
@awaismemon26
Copy link
Author

@awaismemon26 thanks this is great 🙏! I only have a few small stylistic suggestions to make this consistent with other resources.

It also looks like this needs a make fmt run on it.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliscott aliscott aliscott left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@aliscott aliscott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Google Cloud Run
3 participants
@awaismemon26 @CLAassistant @aliscott