Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel upgradability #3228

Merged
merged 142 commits into from
May 31, 2024
Merged

Channel upgradability #3228

merged 142 commits into from
May 31, 2024

Conversation

seanchen1991
Copy link
Contributor

@seanchen1991 seanchen1991 commented Apr 7, 2023 •
edited by romac

Closes: #2547

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@seanchen1991 seanchen1991 changed the title Sean/channel upgradability Initial support for channel upgradability Apr 7, 2023
@seanchen1991 seanchen1991 changed the title Initial support for channel upgradability Add chan_upgrade_init and chan_upgrade_try tx commands Apr 12, 2023
romac
romac reviewed Apr 13, 2023
View reviewed changes
crates/relayer-types/src/core/ics04_channel/msgs/chan_open_try.rs Outdated Show resolved Hide resolved
crates/relayer-types/src/core/ics04_channel/msgs/chan_upgrade_init.rs Outdated Show resolved Hide resolved
crates/relayer-cli/src/commands/tx/channel.rs Outdated Show resolved Hide resolved
crates/relayer-cli/src/commands/tx/channel.rs Outdated Show resolved Hide resolved
crates/relayer-cli/src/commands/tx/channel.rs Outdated Show resolved Hide resolved
crates/relayer/src/channel.rs Outdated Show resolved Hide resolved
@ljoss17 ljoss17 marked this pull request as ready for review April 19, 2024 13:33
romac
romac reviewed May 22, 2024
View reviewed changes
crates/relayer-types/src/applications/ics27_ica/error.rs Outdated Show resolved Hide resolved
crates/relayer-types/src/core/ics04_channel/channel.rs Outdated Show resolved Hide resolved
crates/relayer-types/src/core/ics04_channel/channel.rs Outdated Show resolved Hide resolved
crates/relayer-types/src/core/ics04_channel/timeout.rs
return Err(TimeoutError::invalid_timeout(value.to_owned()));
}

// only timeout timestamp are supported at the moment
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open an issue to track this.

crates/relayer-types/src/core/ics04_channel/version.rs Show resolved Hide resolved
crates/relayer/src/channel.rs Outdated Show resolved Hide resolved
crates/relayer/src/channel.rs Outdated Show resolved Hide resolved
crates/relayer/src/channel.rs Outdated Show resolved Hide resolved
crates/relayer/src/event/source/websocket/extract.rs Show resolved Hide resolved
tools/check-guide/Cargo.toml Outdated Show resolved Hide resolved
@romac
Copy link
Member

romac commented May 30, 2024

Absolutely amazing work, thank you! 🙏 🚀 💐

@ljoss17 ljoss17 mentioned this pull request May 30, 2024
Open
5 tasks
@romac romac merged commit fc8376b into master May 31, 2024
33 checks passed
@romac romac deleted the sean/channel-upgradability branch May 31, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljoss17 ljoss17 ljoss17 left review comments

@romac romac romac approved these changes

Assignees
No one assigned
Labels
O: channel-upgradeability Objective: related to channel upgradeability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for channel upgradability
3 participants
@seanchen1991 @romac @ljoss17