New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7892 - Add fileupload-advanced in a homepage widget and forms #8710
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏻
a) What about making it work in a field in a grid http://localhost:4000/components/form/example-inputs-simple.html so more options that just widget will work?
b) What about making the height responsive/adjustable too?
I think is more worth considering because maybe they dont do it in a widget and want it to be sizable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://localhost:4000/components/fileupload-advanced/example-in-forms.html, when resizing the window:
- the last row 1st component is not the same size as the other.
- the upload status overshoots the rectangle
Screen.Recording.2024-05-15.at.7.50.43.PM.mov
Not sure if this is nit picking, but In http://localhost:4000/components/fileupload-advanced/example-in-a-homepage-widget.html, the bottom of each horizontal bars some how overlaps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain the details for making this change. What existing problem does the pull request solve?
This PR adds an example of fileupload-advanced in homepage widget and forms.
Related github/jira issue (required):
Closes #7892
Steps necessary to review your pull request (required):
Included in this Pull Request:
- [ ] An e2e or functional test for the bug or feature.