Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7892 - Add fileupload-advanced in a homepage widget and forms #8710

Merged
merged 10 commits into from May 21, 2024

Conversation

ericangeles
Copy link
Contributor

@ericangeles ericangeles commented May 10, 2024

Explain the details for making this change. What existing problem does the pull request solve?

This PR adds an example of fileupload-advanced in homepage widget and forms.

Related github/jira issue (required):

Closes #7892

Steps necessary to review your pull request (required):

Included in this Pull Request:
- [ ] An e2e or functional test for the bug or feature.

  • A note to the change log.

@ericangeles ericangeles requested a review from a team as a code owner May 10, 2024 10:12
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

a) What about making it work in a field in a grid http://localhost:4000/components/form/example-inputs-simple.html so more options that just widget will work?

b) What about making the height responsive/adjustable too?

I think is more worth considering because maybe they dont do it in a widget and want it to be sizable

@ericangeles ericangeles changed the title 7892 - Add fileupload-advanced in a homepage widget 7892 - Add fileupload-advanced in a homepage widget and forms May 14, 2024
tmcconechy
tmcconechy previously approved these changes May 14, 2024
@ericangeles ericangeles added the ready for qa Ready for QA to review label May 15, 2024
Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://localhost:4000/components/fileupload-advanced/example-in-forms.html, when resizing the window:

  1. the last row 1st component is not the same size as the other.
  2. the upload status overshoots the rectangle

image

Screen.Recording.2024-05-15.at.7.50.43.PM.mov

Not sure if this is nit picking, but In http://localhost:4000/components/fileupload-advanced/example-in-a-homepage-widget.html, the bottom of each horizontal bars some how overlaps

image

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Galaxy Z Fold 5 - Text overflows outside the border

image

image

RTL
image

iPhone 15 Pro Max - Passed

image

image

Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The status of the upload is now within the rectangle.

The first component on the last row is still not aligned when resizing.

image

In RTL, same scenario and the right padding while resizing vanishes
image

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected:

image

image

image

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!
issues were now fixed
image
image
image
image

@ericangeles ericangeles merged commit 7ff2913 into main May 21, 2024
2 checks passed
@ericangeles ericangeles deleted the 7892-fileupload-advanced-responsive branch May 21, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Ready for QA to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileUploadAdvanced: Ability to resize responsively
5 participants