Chore: Fix app menu buttons #8706
Conversation
There was a problem hiding this comment.
Just to confirm @tmcconechy no hover state for buttons in the app menu?
Main
Screen.Recording.2024-05-10.at.2.04.55.PM.mov
Current Branch
Screen.Recording.2024-05-10.at.2.06.51.PM.mov
|
@n-ace-ancog no hover for X and caret icon based on old version https://4880-enterprise.demo.design.infor.com/components/applicationmenu/example-filterable.html But there is one on https://4880-enterprise.demo.design.infor.com/components/applicationmenu/example-personalized-roles.html Updated the steps to reflect the other example. |
|
@janahintal thanks! I fixed for classic mode. Woops forgot about it |
|
@n-ace-ancog ok fixed that issue |
There was a problem hiding this comment.
Screen.Recording.2024-05-14.at.3.04.12.PM.mov
Screen.Recording.2024-05-14.at.3.06.52.PM.mov
https://fix-app-menu-enterprise.demo.design.infor.com/components/applicationmenu/example-personalized-role-switcher.html?theme=classic&mode=light&colors=default - Still failing on my end (Classic - Light and High Contrast Mode.)
Failing on |
There was a problem hiding this comment.
Screen.Recording.2024-05-14.at.3.04.12.PM.mov
Screen.Recording.2024-05-14.at.3.06.52.PM.mov
https://fix-app-menu-enterprise.demo.design.infor.com/components/applicationmenu/example-personalized-role-switcher.html?theme=classic&mode=light&colors=default - Still failing on my end (Classic - Light and High Contrast Mode.)
tmcconechy
dismissed stale reviews from janahintal, ericangeles, and n-ace-ancog
via
dca2dd5
|
@jbrcna @glenlieorillo fixed that hover issue in classic. Try one last time (hopefully) |
There was a problem hiding this comment.
Working now as expected in Classic. Thanksss, @tmcconechy!
Screen.Recording.2024-05-14.at.10.45.53.PM.mov
Explain the details for making this change. What existing problem does the pull request solve?
I found the hover state on app menu buttons looked bad.
Related github/jira issue (required):
Fixes #8707
Steps necessary to review your pull request (required):