Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NG1659 - Monthview Add Day #8704

Merged
merged 10 commits into from May 22, 2024
Merged

NG1659 - Monthview Add Day #8704

merged 10 commits into from May 22, 2024

Conversation

tjamesallen15
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?

This pull request will fix monthview not updating after changing activeDate.

Related github/jira issue (required):
Closes infor-design/enterprise-ng#1659

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@tjamesallen15 tjamesallen15 marked this pull request as ready for review May 9, 2024 11:10
@tjamesallen15 tjamesallen15 requested a review from a team as a code owner May 9, 2024 11:10
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjamesallen15 the monthview isnt visible on the example?

Screenshot 2024-05-09 at 10 18 53 AM

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-05-10.at.1.57.26.PM.mov

It is not working accordingly in RTL.

Screen.Recording.2024-05-10.at.2.11.32.PM.mov

Copy link
Contributor

@janahintal janahintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not working in RTL on my end
image

@n-ace-ancog
Copy link

n-ace-ancog commented May 16, 2024

@tjamesallen15 does it add a day based on today's date or any selected date? Seems like its only doing the 1st one. Let me know if this is expected.

Screen.Recording.2024-05-16.at.8.40.41.PM.mov

Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected:

Screen.Recording.2024-05-21.at.11.16.00.AM.mov
Screen.Recording.2024-05-21.at.11.17.04.AM.mov

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. nice work!
Large GIF (940x554)
Large GIF (940x554)

@ericangeles ericangeles merged commit 532dc96 into main May 22, 2024
2 checks passed
@ericangeles ericangeles deleted the NG1659-monthview-activedate branch May 22, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SohoMonthview: Won't reflect date changes outside a component once monthviewOptions are used
7 participants